chore: add CoderClient class #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Apr 23, 2024
Comment on lines
+159
to
+164
| this.sdkApi = { | ||
| getUserLoginType: this.getUserLoginType, | ||
| getWorkspaceBuildParameters: this.getWorkspaceBuildParameters, | ||
| getWorkspaces: this.getWorkspaces, | ||
| getWorkspacesByRepo: this.getWorkspacesByRepo, | ||
| }; |
There was a problem hiding this comment.
This was originally the actual Coder SDK until I started running into the issues with the TS file parsing
Hoping to get that swapped back in ASAP
Parkreiner
commented
Apr 23, 2024
Comment on lines
+178
to
+184
| // Set up logic for syncing client snapshots to auth state changes | ||
| this.authApi.subscribe(newAuthSnapshot => { | ||
| const latestClientSnapshot = this.getStateSnapshot(); | ||
| if (newAuthSnapshot.isTokenValid !== latestClientSnapshot.isAuthValid) { | ||
| this.notifySubscriptionsOfStateChange(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This is the main thing I was talking about in the StateSnapshotManager PR with how it's a little clunky to get two snapshots to be related to each other
|
Closing this out in favor of a new series of PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of the PRs for #107
Changes made
CoderClientclasserrorsfile for custom error definitions