Skip to content

chore(Coder plugin): add tests for auth fallback UI #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 65 commits into
base: main
Choose a base branch
from

Conversation

Parkreiner
Copy link
Member

Addendum to #128

Changes made

  • Added tests for fallback UI logic
  • Tucked more stuff into the auth fallback's layout effect logic to help keep things more organized

@Parkreiner Parkreiner self-assigned this May 24, 2024
Comment on lines +452 to +454
const mainAppRoot = document.querySelector<HTMLElement>(
BACKSTAGE_APP_ROOT_ID,
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just decided to tuck this in here to keep the layout effect logic more self-contained

@Parkreiner Parkreiner changed the title chore: add tests for auth fallback UI chore(Coder plugin): add tests for auth fallback UI May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant