Skip to content

Fix tsc failure #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix tsc failure #21

merged 1 commit into from
Mar 11, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Mar 7, 2024

Broken in #14, @bpmct do you have any context on these changes? Reverting this fixes the build pipeline, but I am not sure if it is breaking something else.

@code-asher code-asher requested review from bpmct and Parkreiner March 7, 2024 21:54
@Parkreiner
Copy link
Member

Just making sure before I approve this: was the real issue that we were accidentally importing a version of the Coder plugin that wasn't published?

I made this change for the API docs PR – we were trying to import Coder v0.0.0, when the only version we have available is v0.0.1

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually never mind – I'm still running into issues with the current setup. I was wrong here

@code-asher
Copy link
Member Author

Yeah the problem was when running tsc it tries to import from dist which has not been built yet, instead of just directly importing the src/index.ts.

@code-asher code-asher merged commit f94fb60 into main Mar 11, 2024
@code-asher code-asher deleted the asher/fix-tsc branch March 11, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants