-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: clean up and consolidate config values in codebase #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
approved these changes
Mar 25, 2024
code-asher
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite the
CoderAppConfig.templateName
update, but I felt like the codebase was on the cusp of getting too complex for its own good. I think that some of the complexity is a bit unavoidable, since we still have to deal with Backstage APIs, but this PR consolidates a lot of it into fewer filesChanges
CoderAppConfig
andCoderWorkspacesConfig
CoderAppConfig
isn't really changed, but the newCoderWorkspacesConfig
is the oldCoderEntityConfig
andCoderWorkspacesConfig
combined togethertemplateName
change on the horizon)useCoderEntityConfig
touseCoderWorkspacesConfig
anduseCoderWorkspaces
touseCoderWorkspacesQuery
CoderWorkspacesConfig.creationUrl
property which will always be defineduseCoderWorkspacesConfig
Notes
templateName
should be quick. Hoping to get that in before Wednesday.