fix: make sure Coder plugin indicates when a workspace is being deleted #82
Conversation
| @@ -226,6 +230,37 @@ export const WorkspacesListItem = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| const deletingStatuses: readonly WorkspaceStatus[] = ['deleting', 'deleted']; | |||
There was a problem hiding this comment.
Should deleted be moved to offline? Worried folks might assume a workspace is stuck in a transient state.
There was a problem hiding this comment.
Actually, that's a good call. I think I over-complicated things, and we can keep the status a binary offline/online
Will fix really quick
There was a problem hiding this comment.
I just realized how unlikely we are to show deleted workspaces in a filtered list view.
There was a problem hiding this comment.
Well, I think it still makes sense to make the change – at the very least, the deleting workspaces would show up for "owner:me", which is the first filter people are going to see
There was a problem hiding this comment.
@Parkreiner I like deleting! We can definitely keep this addition! I more meant that if a workspace is deleted, it is also offline.
In general, these boundary states (deleting, starting, etc) are useful and down the road I'd love to expose more of them as you've done here.
plugins/backstage-plugin-coder/src/components/CoderWorkspacesCard/WorkspacesListItem.tsx
Outdated
Show resolved
Hide resolved
| type AvailabilityStatus = 'online' | 'offline' | 'deleting'; | ||
|
|
||
| function getAvailabilityStatus(workspace: Workspace): AvailabilityStatus { | ||
| const currentStatus = workspace.latest_build.status; |
There was a problem hiding this comment.
I find myself again really wishing we had pattern matching!
No issue to link – something I noticed in the past few days.
Changes made
WorkspacesListItem