Skip to content
This repository was archived by the owner on Oct 17, 2021. It is now read-only.

Update help output #17

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Update help output #17

merged 3 commits into from
Aug 4, 2020

Conversation

fuskovic
Copy link
Contributor

What does this do?

Updates the help output.

Why?

It looks like this :

Usage: coder users [subcommand] <flags>

Aliases: [u usr]interact with user accounts

Commands:
        ls  - list all users

But we want it to look like this:

Usage: coder users [subcommand] <flags>

Aliases: u, usr

Description: interact with user accounts

Commands:
        ls  - list all users

Were the tests updated?

Yes

Are they still passing?

Yes

=== RUN   TestSubCmdAliases/s
=== RUN   TestSubCmdAliases/sc
=== RUN   TestSubCmdAliases/sub
--- PASS: TestSubCmdAliases (0.00s)
    --- PASS: TestSubCmdAliases/s (0.00s)
    --- PASS: TestSubCmdAliases/sc (0.00s)
    --- PASS: TestSubCmdAliases/sub (0.00s)
=== RUN   TestSubcmdAliasesInParentCmdHelpOutput
--- PASS: TestSubcmdAliasesInParentCmdHelpOutput (0.00s)
=== RUN   TestSubCmdHelpOutput
=== RUN   TestSubCmdHelpOutput/subcmd_w/nested_subcmd.
=== RUN   TestSubCmdHelpOutput/subcmd_w/no_nested_subcmds.
--- PASS: TestSubCmdHelpOutput (0.00s)
    --- PASS: TestSubCmdHelpOutput/subcmd_w/nested_subcmd. (0.00s)
    --- PASS: TestSubCmdHelpOutput/subcmd_w/no_nested_subcmds. (0.00s)
PASS
ok  	go.coder.com/cli	0.177s

@fuskovic fuskovic requested review from scsmithr, coadler and cmoog July 31, 2020 15:57
creack
creack reviewed Aug 4, 2020
View reviewed changes
Copy link

@creack creack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nit-picky details, but lgtm.

@fuskovic fuskovic requested a review from creack August 4, 2020 15:15
@fuskovic fuskovic force-pushed the update-help-output-format branch from a284572 to 6615750 Compare August 4, 2020 16:31
@fuskovic fuskovic merged commit 42c337d into master Aug 4, 2020
@fuskovic fuskovic deleted the update-help-output-format branch August 4, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creack creack creack approved these changes

@cmoog cmoog cmoog approved these changes

@scsmithr scsmithr Awaiting requested review from scsmithr

@coadler coadler Awaiting requested review from coadler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuskovic @creack @cmoog