Remove <type> from onMessage

code-asher · code-asher · commit 31b67062b013 · 2020-11-12T11:17:45.000-06:00
Turns out that while Typescript can't infer the callback return type
from it, Typescript can do the opposite and infer it from the callback
return type.
diff --git a/src/node/vscode.ts b/src/node/vscode.ts
@@ -69,7 +69,7 @@ export class VscodeProvider {
       vscode,
     )
 
-    const message = await this.onMessage<ipc.OptionsMessage>(vscode, (message): message is ipc.OptionsMessage => {
+    const message = await this.onMessage(vscode, (message): message is ipc.OptionsMessage => {
       // There can be parallel initializations so wait for the right ID.
       return message.type === "options" && message.id === id
     })
@@ -104,7 +104,7 @@ export class VscodeProvider {
       dispose()
     })
 
-    this._vscode = this.onMessage<ipc.ReadyMessage>(vscode, (message): message is ipc.ReadyMessage => {
+    this._vscode = this.onMessage(vscode, (message): message is ipc.ReadyMessage => {
       return message.type === "ready"
     }).then(() => vscode)
 
