Skip to content

Extension help dismiss button disappears #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
code-asher opened this issue Mar 1, 2021 · 1 comment · Fixed by #2801
Closed

Extension help dismiss button disappears #2799

code-asher opened this issue Mar 1, 2021 · 1 comment · Fixed by #2801
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
v3.9.1

Comments

@code-asher
Copy link
Member

  • Switch to extensions sidebar
  • Refresh page
  • Dismiss button disappears after a while

If a different sidebar is showing while VS Code loads then you switch to the extensions sidebar everything is OK. It's only when you load the page with the extensions sidebar enabled.
@code-asher code-asher added the bug Something isn't working label Mar 1, 2021
@code-asher code-asher added this to the v3.9.1 milestone Mar 1, 2021
@code-asher code-asher self-assigned this Mar 1, 2021
code-asher added a commit that referenced this issue Mar 1, 2021
@code-asher
Add div for inner extension helper text
6dd8b63 
The theme callback would set innerHTML on the header which wipes out the
dismiss button. With an inner div we can replace the inner HTML without
worrying about other elements in the header.

Closes #2799.
@greyscaled greyscaled linked a pull request Mar 2, 2021 that will close this issue
Fix disappearing dismiss button on extension help #2801
Merged
@greyscaled
Copy link
Contributor

Fixed by 3e081ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging a pull request may close this issue.

Fix disappearing dismiss button on extension help coder/code-server
2 participants
@greyscaled @code-asher