Skip to content

Cannot 'Open Folder...' on code-server Welcome Page #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JammSpread opened this issue Mar 17, 2021 · 12 comments · Fixed by #3437
Closed

Cannot 'Open Folder...' on code-server Welcome Page #2921

JammSpread opened this issue Mar 17, 2021 · 12 comments · Fixed by #3437
Assignees
@jsjoeio
Labels
bug Something isn't working
Milestone
3.10.2

Comments

@JammSpread
Copy link
Contributor

JammSpread commented Mar 17, 2021 •
edited
Loading

OS/Web Information

  • Web Browser: Chrome
  • Local OS: Chrome OS
  • Remote OS: Debian GNU/Linux
  • Remote Architecture: amd64
  • code-server --version: 3.9.1 + 3.9.2

Steps to Reproduce

  1. Load up a fresh setup of code-server without specifying a folder or with --ignore-last-opened on Linux.
    (You could also use the Help: Welcome command.)
  2. Click Open Folder under the Start Section.

Expected

It uses the open folder command specific to your remote OS and you can select a folder.

Actual

Witness nothing happens as after you click the link as the command it references may not even exist on your version of VSCode.

Screenshot

Open Folder

Notes

Has occurred on multiple Linux machines, this is my third remote machine I'm using to report it.

This issue can be reproduced in VS Code: Unknown

Seems to originate from this line. This might occur due to the 'mac-only' class version being used wrongly.
@JammSpread JammSpread changed the title Cannot 'Open Folder...' on code-server welcome page. Cannot 'Open Folder...' on code-server welcome page Mar 17, 2021
@JammSpread JammSpread changed the title Cannot 'Open Folder...' on code-server welcome page Cannot 'Open Folder...' on code-server Welcome Page Mar 17, 2021
@jsjoeio jsjoeio added the needs-investigation This issue needs to be further investigated label Mar 17, 2021
@jsjoeio jsjoeio modified the milestone: v3.9.3 Mar 17, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 17, 2021

Thanks for opening this issue and adding all the details @JammSpread ! Yeah that's weird they have the mac-only class there. I'm guessing you're right. We'll look into this!

@oxy oxy added waiting-for-info Waiting for more information from submitter and removed needs-investigation This issue needs to be further investigated labels Mar 18, 2021
@oxy
Copy link

oxy commented Mar 18, 2021

Tested on Fedora 34 with the official code-server rpm right now, using either --ignore-last-opened or Help: Welcome and then clicking Open Folder worked on my environment, on both Chromium and Firefox.

Could this be Chrome OS specific?

@oxy
Copy link

oxy commented Mar 18, 2021

@JammSpread could you view the page with inspect element and find out which li element is displayed - the macOS one or the Linux/Windows one (or is something else being displayed)?

@JammSpread
Copy link
Contributor Author

JammSpread commented Mar 18, 2021 •
edited
Loading

Sure, I'll try that soon. If it did work for you it could be that it doesn't resolve Chrome OS to be either.

@jsjoeio jsjoeio modified the milestones: v3.9.3, On Deck Mar 22, 2021
@JammSpread
Copy link
Contributor Author

I'm very sorry for the late reply.
After trying and inspecting on the local OS (Chrome OS) and Chrome/Firefox on Debian, I've come to a similar conclusion.

Could this be Chrome OS specific?

The assumption seems to be correct.
It seems that Chrome OS is falsely detected as macOS and thus uses its platform-specific command.
This doesn't occur, in contrast, on standard Linux environments.

@JammSpread
Copy link
Contributor Author

This might be just a speculation but shouldn't it use the remote OS' command and not the detected local OS'?

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 30, 2021

Do we know if this is an upstream issue or specific to code-server?

Can it be reproduced on Codespaces?

@JammSpread
Copy link
Contributor Author

I haven't been able to access the Codespaces Beta however this is reproducible in Gitpod.
It seems it may be upstream and an issue with handling Chrome OS.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 30, 2021

Ah gotcha. Well that's a good sign then!

Shoot, I wish I had access to Chrome OS. Or if there were a way for me to lend you access to my Codespaces Beta. Then I could try and reproduce and we could file upstream.

@JammSpread
Copy link
Contributor Author

You might be able to reproduce it by using a similar or the same user agent I have.

Mozilla/5.0 (X11; CrOS x86_64 13729.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.95 Safari/537.36

You might be able to make use of this through a browser extension or by manually modifying your HTTP(S) requests.

@jsjoeio jsjoeio added needs-investigation This issue needs to be further investigated and removed waiting-for-info Waiting for more information from submitter labels Mar 30, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 30, 2021

Ooo didn't think about that. That could work! Okay, great. I think we have what we need to investigate this further. Thanks a ton for your work @JammSpread! 🎉

@jsjoeio jsjoeio mentioned this issue May 20, 2021
Closed
@jsjoeio jsjoeio added the bug Something isn't working label May 20, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented May 20, 2021

I was able to reproduce locally in #3427

@jsjoeio jsjoeio modified the milestones: On Deck, 3.11.0 May 20, 2021
@jsjoeio jsjoeio removed the needs-investigation This issue needs to be further investigated label May 20, 2021
@sestegra sestegra mentioned this issue May 21, 2021
Closed
@jsjoeio jsjoeio self-assigned this May 21, 2021
@jsjoeio jsjoeio mentioned this issue May 21, 2021
Merged
2 tasks
@sestegra sestegra mentioned this issue May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working
Projects
None yet
Milestone
3.10.2
Development

Successfully merging a pull request may close this issue.

fix: use correct command to Open Folder on Welcome page coder/code-server
3 participants
@jsjoeio @oxy @JammSpread