Skip to content

Typing not working #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cTatu opened this issue Mar 24, 2019 · 18 comments
Closed

Typing not working #328

cTatu opened this issue Mar 24, 2019 · 18 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cTatu
Copy link

cTatu commented Mar 24, 2019

  • code-server version: 1.32.0-310
  • OS Version: Ubuntu 18.04.1 LTS & Kernel 4.15.0-1036-azure

Description

Firstly, sometimes when I open a new terminal the editor stop recording my keystrokes (it's not because focusing), no matter what I type it's not doing anything, I can still select the code and even delete it but I cannot add nothing. Sometimes the problem is solved by closing the terminal.

I had running it on an azure container for like 3-4 days and I connected to it several times since then.

Steps to Reproduce

(Not sure at 100%, sometimes it stops registering the keys suddenly)

  1. Create new terminal
  2. Type whatever in there
  3. Click back to text editor
  4. Try to type anything and doesn't work. Only the backspace bar
@cTatu cTatu added the bug Something isn't working label Mar 24, 2019
@nol166
Copy link
Contributor

nol166 commented Mar 24, 2019

I found this issue when working with the search field in extensions. The workaround was to right click i the search field for extensions, the left click and typing goes back to normal. As a side note, it seems that the extension search field grabs focus and doesn't let go even when you switch back to (as in your situation) the code editor.

@ShannonMasters
Copy link

Image from dockerhub (https://hub.docker.com/r/codercom/code-server) (no version tags.. last updated 9 days ago at time of this post).

I have the same problems as described by others above, but also noticed if you highlight any text in the actual code editor you also lose the ability to type as well. The cursor still blinks to indicate focus, but until you deselect the text you cannot resume typing.

@ShannonMasters
Copy link

ShannonMasters commented Mar 25, 2019

This also appears to only affect Chrome. I just tested in Firefox Quantum 66.0.1 (64-bit) and it works fine, no loss of ability to type so far.

@sr229
Copy link
Contributor

sr229 commented Mar 26, 2019

Can confirm this bug as well. Sometimes the editor does not accept input when I was process of making #225 in Crostini.

@frenck
Copy link

frenck commented Mar 26, 2019

This seems to workaround this issue:

image

If I disable selection clipboard, this issue seems to be gone.

@kylecarbs kylecarbs self-assigned this Mar 26, 2019
@kylecarbs kylecarbs added this to the In Progress milestone Mar 26, 2019
@buckley310
Copy link

I am running into same/similar behavior in the settings screen (UI version). Whenever I open the settings screen, several keys stop working (enter, down arrow key, etc). I can usually convince it to go back to normal by right-clicking in the search box in settings, and then closing the settings tab.
The JSON settings screen doesn't do this, only the UI settings screen.
Firefox 66.0.3 is affected for me. Cannot reproduce in Chromium 73.0.3683.103.

@ShannonMasters
Copy link

can confirm the workaround that frenck posted for disabling selection clipboard works. In the interim of this getting fixed, I have just included in my docker file a line to copy a settings.json file with:

{
"editor.selectionClipboard": false
}

@buckley310
Copy link

"editor.selectionClipboard": false did not resolve the settings screen issue in my test.

@sr229
Copy link
Contributor

sr229 commented May 24, 2019

I don't think this is persistent on newer versions. Let me know if there are other people still getting this.

@buckley310
Copy link

I am still getting this issue in the latest docker image with firefox 67.

@buckley310
Copy link

The only place I can seem to reproduce it now is the search box on the settings screen though. None of the other places seem to trigger it anymore.

@iglizar
Copy link

iglizar commented Jun 13, 2019

Worked for me, thanks so much!

This seems to workaround this issue:

image

If I disable selection clipboard, this issue seems to be gone.

@sr229
Copy link
Contributor

sr229 commented Jun 14, 2019

I think we can close this off @coadler?

@coadler coadler closed this as completed Jun 14, 2019
@coadler
Copy link
Contributor

coadler commented Jun 14, 2019

Actually kyle had this assigned, will let him close

@coadler coadler reopened this Jun 14, 2019
@buckley310
Copy link

I can still recreate this issue

@code-asher
Copy link
Member

I attempted to recreate this on v2 but it seems to work as expected with or without the selection clipboard. If anyone has issues on v2 lemme know and we can reopen.

@buckley310
Copy link

@code-asher I can still recreate the typing issues i mentioned earlier. seems to affect firefox, but not chrome in my testing. on a fresh instance of code-server:v2, i can open a new document and type just fine, but if i do Ctrl+, to open the UI settings screen, then close the settings tab with the mouse, not all my keys work in the text editor now. notably, down arrow key and Enter. it happens with or without selection keyboard enabled. If nobody else can recreate it, i can document more thoroughly. If it's thought to be a similar but separate bug i can leave this thread alone.

@code-asher
Copy link
Member

Ah thanks for those steps! I was able to replicate. I opened #1135 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

11 participants