Skip to content

[dev]: update node/constants.ts test to cover L19 #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue May 4, 2021 · 0 comments · Fixed by #3290
Closed

[dev]: update node/constants.ts test to cover L19 #3289

jsjoeio opened this issue May 4, 2021 · 0 comments · Fixed by #3290
Assignees
@jsjoeio
Labels
testing Anything related to testing
Milestone
v3.10.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented May 4, 2021 •
edited
Loading

We don't currently have a test for L19 in src/node/constants.ts. This task is to fix that.

https://github.com/cdr/code-server/blob/main/src/node/constants.ts#L19
@jsjoeio jsjoeio self-assigned this May 4, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone May 4, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label May 4, 2021
@jsjoeio jsjoeio changed the title [dev]: update node/constants.ts test to cover L18 [dev]: update node/constants.ts test to cover L19 May 4, 2021
@jsjoeio jsjoeio modified the milestones: v3.10.0, v3.11.0 May 7, 2021
@jsjoeio jsjoeio linked a pull request May 14, 2021 that will close this issue
feat(testing): add test for src/node/constants.ts #3290
Merged
@jsjoeio jsjoeio closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging a pull request may close this issue.

feat(testing): add test for src/node/constants.ts coder/code-server
1 participant
@jsjoeio