Skip to content

Delete doesn't actually delete #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nol166 opened this issue Apr 4, 2019 · 4 comments · Fixed by #857
Closed

Delete doesn't actually delete #429

nol166 opened this issue Apr 4, 2019 · 4 comments · Fixed by #857
Labels
bug Something isn't working
Milestone
April 2019

Comments

@nol166
Copy link
Contributor

nol166 commented Apr 4, 2019

  • code-server version: v1.604-vsc1.32.0
  • OS Version: macOS 10.14.4 (18E226)

Description

Deleting files from the file tree inside the IDE doesn't actually delete them from disk. It seems to simply remove them from the workspace until code-server is restarted

Expected Files should be sent to the trash/recycle bin

Steps to Reproduce

  1. Run code-server
  2. Right click on a file/folder
  3. Choose delete
  4. Check the local filesystem for that file/folder
@nol166 nol166 added the bug Something isn't working label Apr 4, 2019
@ghost
Copy link

ghost commented Apr 6, 2019

also on Mac, and does not work.

@Egoscio-zz
Copy link

Egoscio-zz commented Apr 21, 2019 •
edited
Loading

@nol166 One part of your issue mentions the IDE doesn't actually delete them from disk while the other mentions Files should be sent to the trash/recycle bin. I personally interpret those two statements as different things. code-server is technically sending files to its equivalent of a trash/recycle bin (the .Trash-1000 folder), but it's not deleting the files immediately from disk. That's because code-server abides by your settings for Files: Enable Trash, which by default is set to true. If you set files.enableTrash to false, code-server will immediately delete the file.

@kylecarbs kylecarbs added this to the April 2019 milestone Apr 25, 2019
@code-asher
Copy link
Member

code-asher commented Apr 25, 2019 •
edited
Loading

Looks like trash depends on macos-trash (only when on a Mac obviously) so I suppose we'll want to bundle and extract that with the binary the way we do with ripgrep.

@yyynnn
Copy link

yyynnn commented May 1, 2019 •
edited
Loading

This happens on centos as well. Delete file then refresh fs -> boom file still in the directory

rm file works

@code-asher code-asher mentioned this issue Jul 18, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
April 2019
Development

Successfully merging a pull request may close this issue.

[v2] Rewrite code-server to use new web stuff coder/code-server
5 participants
@Egoscio-zz @nol166 @kylecarbs @yyynnn @code-asher