-
Notifications
You must be signed in to change notification settings - Fork 5.9k
127.0.0.1 by default vs 0.0.0.0 #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nol166 is there any record of this discussion that you can link to this issue? |
@nhooyr Discussed it this morning and asked me to make this issue https://superuser.com/questions/949428/whats-the-difference-between-127-0-0-1-and-0-0-0-0 |
I think the overwhelming use case of |
I think a better solution would be to just add a warning. Changing the default behavior would most likely break a lot of scripts/deployments |
Yea I agree it would be a bad idea to change the behaviour. I guess what we really want is to listen on localhost if the |
That seems sensible to me. I could see this affecting people behind reverse proxies that handle auth/tls upstream though, so we should be sure to document the change on the next release |
updated the pr |
PR is here for people from the future following this thread #441 |
code-server
version: v1.604-vsc1.32.0Description
It has been discussed that using 127.0.0.1 might be better than using 0.0.0.0 for the default host for security reasons when running code-server. A user should have to explicitly set 0.0.0.0 as the host if they want to use it with the
-h
flagSteps to Reproduce
INFO Starting webserver... {"host":"0.0.0.0","port":8443}
The text was updated successfully, but these errors were encountered: