Skip to content

[Helm chart] Typo in Helm chart notes #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
louis030195 opened this issue Nov 13, 2021 · 2 comments · Fixed by #4515
Closed

[Helm chart] Typo in Helm chart notes #4504

louis030195 opened this issue Nov 13, 2021 · 2 comments · Fixed by #4515
Labels
waiting-for-info Waiting for more information from submitter
Milestone
4.0.0 - pre-release

Comments

@louis030195
Copy link

In
https://github.com/cdr/code-server/blob/66060408354c223918cb1df4b0cb8849aad4c9c7/ci/helm-chart/templates/NOTES.txt#L20

you forgot the namespace, i.e. --namespace {{ .Release.Namespace }
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 15, 2021 •
edited
Loading

Oh no! cc @jlandowner was this supposed to be updated in your PR? (I actually haven't touched the NOTES.txt so apologies if I missed in my review)

@jsjoeio jsjoeio added the waiting-for-info Waiting for more information from submitter label Nov 15, 2021
@jlandowner
Copy link
Contributor

Do you mean #4497? It's not for NOTES.txt.
This is another issue.

@jlandowner jlandowner mentioned this issue Nov 16, 2021
Merged
@jsjoeio jsjoeio added this to the 4.0.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting-for-info Waiting for more information from submitter
Projects
None yet
Milestone
4.0.0 - pre-release
Development

Successfully merging a pull request may close this issue.

fix NOTE.txt jlandowner/code-server
3 participants
@jsjoeio @louis030195 @jlandowner