-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Bug]: Slowness when reloading code-server started with --proxy-domain #6088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I briefly attempted to reproduce on 4.11.0 but so far have not seen the slowness with I used localhost as my proxy domain (so |
Code-wise I am not sure how this would happen; the proxy domain flag is checked against the host on each request but crazy for that to take nearly two minutes! Does this reliably reproduce for you when you add/remove the |
@code-asher Thanks for looking into it. I tried this again today and was not able to reproduce the slowness. I've been hosting this on a GCP compute engine instance and wonder if there were intermittent issues on that side. This is my nginx file:
Let me know if there's anything I can do to help test/figure out where the error is coming from. |
That config looks good to me. The Aha yup I am able to reproduce with We will need to handle the code differently, something like this should work.
In the meantime, is your app opening web sockets to the right spot? |
Is there an existing issue for this?
OS/Web Information
code-server --version
: 4.11.0Steps to Reproduce
Expected
Code server in browser should reload quickly
INFO Creating a socket (...) was successful after 250 ms
This step in the browser console completes ~250ms if code server started without proxy domain.
Actual
Blank screen in browser while code server reloads
INFO Creating a socket (...) was successful after 112877 ms
This step takes much longer than usual.
During this time, the web service is running at 8000.example.com and responsive.
Logs
The following error is seen:
Screenshot/Video
No response
Does this issue happen in VS Code or GitHub Codespaces?
Are you accessing code-server over HTTPS?
Notes
No response
The text was updated successfully, but these errors were encountered: