Skip to content

VSCODE_NLS_CONFIG returns undefined, No process variable for VSCODE_NLS_CONFIG #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jots opened this issue May 15, 2019 · 3 comments · Fixed by #857
Closed

VSCODE_NLS_CONFIG returns undefined, No process variable for VSCODE_NLS_CONFIG #685

jots opened this issue May 15, 2019 · 3 comments · Fixed by #857

Comments

@jots
Copy link

jots commented May 15, 2019

Description

console shows:
ide.main.92c1f4.js:67 Activating extension 'wraith13.unsaved-files-vscode' failed: Unexpected token u in JSON at position 0.

I have tried installing via UI, command line and vsix download.
extension works in normal vscode

@jots
Copy link
Author

jots commented May 15, 2019

fixed this by changing line 26 of
~/.local/share/code-server/extensions/wraith13.unsaved-files-vscode-2.0.0/out/src/extension.js
// const localeTableKey = JSON.parse(process.env.VSCODE_NLS_CONFIG).locale;
const localeTableKey = "en-us";

Can we get a VSCODE_NLS_CONFIG in code-server? there are a few extensions that use it.
Also, in chrome devtools opened on code-server window I don't see "process.env" (or process for that matter) but in devtools for regular vscode I do see it.

@sr229
Copy link
Contributor

sr229 commented May 17, 2019

@jots process is a Node.js API. We don't want that lurking in code-server's side.

CC @multishifties

@MichaelDesantis
Copy link
Contributor

So, @foresthoffman would normally have been the guy to talk to for anything extension related. Microsoft TOS doesn't allow us to use their marketplace directly.

I see no reason why we can't add a VSCODE_NLS_CONFIG env variable. @jots Can you change this issue to something like:

VSCODE_NLS_CONFIG returns undefined, No process variable for VSCODE_NLS_CONFIG, or VSCODE_NLS_CONFIG causing extension install failure?

@jots jots changed the title error installing extension wraith13.unsaved-files-vscode VSCODE_NLS_CONFIG returns undefined, No process variable for VSCODE_NLS_CONFIG May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants