Skip to content

Add npm package and document/cleanup CI and build process #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

Add npm package and document/cleanup CI and build process #1601

merged 2 commits into from
May 7, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented May 4, 2020

Closes many issues that I'll go through later and link.

@nhooyr nhooyr requested a review from code-asher as a code owner May 4, 2020 05:39
@nhooyr nhooyr force-pushed the fixes branch 18 times, most recently from 244644b to 9bf0437 Compare May 5, 2020 06:33
@nhooyr
Copy link
Contributor Author

nhooyr commented May 5, 2020

We have debs/rpms now too.

Please review @code-asher

I'll add alpine too.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 5, 2020

Actually lets not add alpine, just change docs to tell people to use npm package.

@nhooyr
Copy link
Contributor Author

nhooyr commented May 5, 2020

@code-asher This moves the bundled node binary into lib and the code-server script into bin. That way you can easily add the bin directory to your $PATH and use code-server for the self contained releases.

@nhooyr nhooyr force-pushed the fixes branch 7 times, most recently from 9ea486c to e4738b1 Compare May 5, 2020 19:21
code-asher
code-asher reviewed May 5, 2020
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking super fly. rsync is a very nice touch. I assume the commented-out tag parts of the Travis config are just for testing yeah?

@nhooyr nhooyr force-pushed the fixes branch 22 times, most recently from d3646b3 to 25259a7 Compare May 6, 2020 23:24
@nhooyr
Add NPM package, debs, rpms and refactor CI/build process
be032cf 
Closes many issues that I'll prune after adding more docs
for users.
@nhooyr nhooyr requested a review from code-asher May 7, 2020 00:26
@nhooyr nhooyr merged commit c63f1ea into master May 7, 2020
@nhooyr nhooyr deleted the fixes branch May 7, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @code-asher