Skip to content

feat(testing): add playwright #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2021
Merged

feat(testing): add playwright #2643

merged 2 commits into from
Feb 2, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 26, 2021 •
edited
Loading

This PR adds playwright for end-to-end testing. In ci, we now download the code-server artifact, run code-server in ci and then run tests against it.

Changes

  • add playwright to /test/package.json
  • add basic test for login page
  • update ci.yml test job to work with e2e

Additional Notes

Right now, yarn test runs both the unit and the e2e tests. This means it will fail locally if you do not have code-server running. In the future, we should consider separating the tests. We could have test:unit and test:e2e and then have separate jobs for each in ci.

Follow-up issue: #2646

Todos

  • remove pkill node in ci job
  • clean up commit messages

jsjoeio
jsjoeio commented Jan 26, 2021
View reviewed changes
@jsjoeio jsjoeio self-assigned this Jan 28, 2021
jsjoeio
jsjoeio commented Jan 28, 2021
View reviewed changes
jsjoeio
jsjoeio commented Jan 28, 2021
View reviewed changes
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 28, 2021

The macos error looks like it was a network connection error:
image

@jsjoeio jsjoeio mentioned this pull request Jan 28, 2021
Closed
@jsjoeio jsjoeio marked this pull request as ready for review January 28, 2021 18:11
oxy
oxy reviewed Jan 28, 2021
View reviewed changes
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me! Haven't worked much on testing so far - so you might want a second opinion.

@jsjoeio jsjoeio requested review from code-asher and oxy January 28, 2021 23:43
code-asher
code-asher previously requested changes Jan 29, 2021
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite exciting. 😄

@jsjoeio jsjoeio requested a review from code-asher January 29, 2021 18:15
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 29, 2021

Seeing strange errors in the macos release
image

image

image

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 29, 2021

Re-running tests

nhooyr
nhooyr approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

@jsjoeio jsjoeio dismissed code-asher’s stale review February 2, 2021 18:01

I made your changes and Anmol approved!

@jsjoeio jsjoeio merged commit 4c6ad04 into master Feb 2, 2021
@jsjoeio jsjoeio deleted the add-playwright branch February 2, 2021 18:02
@jsjoeio jsjoeio mentioned this pull request Feb 10, 2021
Closed
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr approved these changes

@oxy oxy Awaiting requested review from oxy

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@jsjoeio jsjoeio

Labels
testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsjoeio @nhooyr @oxy @code-asher