Skip to content

chore(deps): deduplicate deps in yarn.lock #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021
Merged

chore(deps): deduplicate deps in yarn.lock #3167

merged 1 commit into from
Apr 19, 2021

Conversation

oxy
Copy link

@oxy oxy commented Apr 19, 2021

Probably a bit of a sledgehammer approach to the whole process; but should reduce duplicate dependencies and maybe save some small amount of space!

@oxy oxy requested a review from a team as a code owner April 19, 2021 16:20
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass this seems good to me. Any thoughts on using that yarn deduplicate thing? Maybe a separate change though.

@oxy
Copy link
Author

oxy commented Apr 19, 2021

At the moment, it should be good enough to run the tool manually whenever things pile up (for eg. from dependabot); we can look into integrating this with our workflow in the future.

@oxy
Copy link
Author

oxy commented Apr 19, 2021

macOS build is still hitting ESOCKETTIMEOUT even when retrying downloads with yarn...

@oxy oxy merged commit f21884c into main Apr 19, 2021
@oxy oxy deleted the yarn-deduplicate branch April 19, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants