Skip to content

fix(lib/vscode): update to 1.56.1 #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021
Merged

fix(lib/vscode): update to 1.56.1 #3351

merged 1 commit into from
May 11, 2021

Conversation

oxy
Copy link

@oxy oxy commented May 11, 2021

No description provided.

@oxy oxy requested a review from a team as a code owner May 11, 2021 18:12
@oxy oxy force-pushed the oxy/vscode-1.56.1 branch from 57374b6 to 03bdba4 Compare May 11, 2021 18:25
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #3351 (32a7369) into main (cc02b5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3351   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc02b5f...32a7369. Read the comment docs.

@oxy oxy force-pushed the oxy/vscode-1.56.1 branch from 03bdba4 to 32a7369 Compare May 11, 2021 18:29
@jsjoeio
Copy link
Contributor

jsjoeio commented May 11, 2021

Do we need to open a separate issue to fix the update-vscode script or was a one-time fluke you think?

@oxy
Copy link
Author

oxy commented May 11, 2021

@jsjoeio I think it might just be a one-time fluke because I've accumulated quite the mess of outdated branches and tags locally - I imagine deleting/recloning might help.

@jsjoeio jsjoeio added this to the v3.11.0 milestone May 11, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some CSS changes? Looks good to me!

@oxy oxy merged commit 74fbb42 into main May 11, 2021
@oxy oxy deleted the oxy/vscode-1.56.1 branch May 11, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants