Skip to content

fix: add timeouts to CI jobs #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

fix: add timeouts to CI jobs #3700

merged 1 commit into from
Jul 1, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jun 30, 2021

This PR adds timeouts to CI jobs to prevent them from running longer than reasonable.

Case: Pre-build checks ran for 1h 51m today because I didn't close an HTTP server in a unit test.

Fixes N/A

@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 30, 2021
@jsjoeio jsjoeio added ci Issues related to ci chore Related to maintenance or clean up labels Jun 30, 2021
@jsjoeio jsjoeio self-assigned this Jun 30, 2021
@jsjoeio jsjoeio marked this pull request as ready for review June 30, 2021 22:19
@jsjoeio jsjoeio requested a review from a team as a code owner June 30, 2021 22:19
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #3700 (8695c87) into main (e9d4f87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3700   +/-   ##
=======================================
  Coverage   60.13%   60.13%           
=======================================
  Files          35       35           
  Lines        1811     1811           
  Branches      365      365           
=======================================
  Hits         1089     1089           
  Misses        606      606           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d4f87...8695c87. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Timeouts are always good.

@jsjoeio jsjoeio merged commit 4dcf3ef into main Jul 1, 2021
@jsjoeio jsjoeio deleted the jsjoeio-add-job-timeouts branch July 1, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up ci Issues related to ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants