fix(ci): build+push image in release flow #3838
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3838 +/- ##
=======================================
Coverage 63.40% 63.40%
=======================================
Files 36 36
Lines 1872 1872
Branches 379 379
=======================================
Hits 1187 1187
Misses 582 582
Partials 103 103 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
As someone who is less familiar with Docker/buildx, I don't think I have enough exp to approve this.
However from a general standpoint,
- great PR description
- this approach feels clean and maintainable
- i appreciate you taking extra precautions and separating into it's own workflow
ci/steps/build-docker-image.sh
Outdated
| @@ -1,12 +1,37 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Should we rename this file? Maybe build-and-push-docker-image.sh?
There was a problem hiding this comment.
I did consider this but felt it was a bit of a mouthful - though am not opposed to it!
There was a problem hiding this comment.
It does seem a bit long haha but I don't want to mislead anyone who might try to run this!
There was a problem hiding this comment.
Could maybe shorten to docker-buildx-push.sh or something.
ci/steps/build-docker-image.sh
Outdated
| echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin | ||
| fi | ||
|
|
||
| docker buildx bake -f ci/release-image/docker-bake.hcl --push |
|
Maybe we should rename the publish workflow as well since it's not the full publish process anymore. |
|
@oxy just checking in on this. Anything we can do to help you move this forward? |
|
@jsjoeio @code-asher ready for a second look and merge! |
Previously, we would build docker images on each CI run, export them, then re-import them and push them on release. However, there appears to be a bug in buildx's export flow, and images can't be re-imported into Docker.
To fix this, I've moved to building and publishing with buildx in the release workflow in one step, and removed the image build step from the main CI flow. I also moved the docker publish process to its own workflow instead of
release.ymlso that it can be re-run independently of the npm+homebrew step.Partially adresses #3814, though a new release needs to be made for the workflow to kick in.