Skip to content

chore: fix docs version to only use latest #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Aug 9, 2021

This PR updates the manifest.json to only include the latest version in the versions key.

Originally, I was going to go with Bruno's suggestion of v3.11.* to include all patches but as Jonathan noted, we really only need to support the latest version in the docs (we don't have that many changes between versions).

Plus, using the specific version like v3.11.1 means it will auto-update with your release-prep script. Using v3.11.* would make it more difficult.

Fixes #3903 (comment)

@jsjoeio jsjoeio requested a review from a team as a code owner August 9, 2021 18:27
@jsjoeio jsjoeio self-assigned this Aug 9, 2021
@jsjoeio jsjoeio added ci Issues related to ci docs Documentation related labels Aug 9, 2021
@jsjoeio jsjoeio added this to the 3.12.0 milestone Aug 9, 2021
@jsjoeio jsjoeio requested review from ashumz and BrunoQuaresma August 9, 2021 18:28
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #3934 (84d11a4) into main (fb11766) will not change coverage.
The diff coverage is n/a.

❗ Current head 84d11a4 differs from pull request most recent head b22ebd8. Consider uploading reports for the commit b22ebd8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3934   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb11766...b22ebd8. Read the comment docs.

Copy link
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjoeio jsjoeio merged commit cde28a0 into main Aug 9, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-doc-versions branch August 9, 2021 20:56
@jsjoeio jsjoeio modified the milestones: 3.12.0, 3.11.2 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues related to ci docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants