-
Notifications
You must be signed in to change notification settings - Fork 5.9k
docs: update section around testing #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4274 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 36 36
Lines 1883 1883
Branches 380 380
=======================================
Hits 1230 1230
Misses 555 555
Partials 98 98 Continue to review full report at Codecov.
|
✨ Coder.com for PR #4274 deployed! It will be updated on every commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. End-to-end tests | ||
2. Script tests | ||
3. Integration tests | ||
4. End-to-end tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking(nice-to-have) it's typically less error-prone to just use 1.
for all of them and let markdown convert them into 1 2 3 4 etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I could remember the point, but @code-asher mentioned a point against doing this so I haven't, but yeah, it probably is less error-prone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahaha yeah because I read these raw in my editor and all I see is 1 1 1 11 1 1 1 1 1 1111 😛 So I always appreciate when the numbering is correct in the source ❤️
Really this should not be done manually, I would use a VS Code plugin or something to number them automatically.
This PR adds more docs around our testing strategy including:
MAINTAINING.md
CONTRIBUTING.md
Fixes #4177