Skip to content

Add warning about 0.0.0.0 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add warning about 0.0.0.0 #441

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a2be81
packages/server/src/cli.ts
Apr 5, 2019
499cc00
Refactor to only use 127.0.0.1 if noauth or allow-http flags are used
Apr 5, 2019
22dad18
Add back readonly
Apr 5, 2019
c609b97
Add warning, remove change of host
Apr 5, 2019
e5b0bfd
Only show message if the host is 0.0.0.0
Apr 8, 2019
a596bc3
Add space between string and pipes
Apr 22, 2019
e8b5295
Add space before pipes
Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/server/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,9 @@ const bold = (text: string | number): string | number => {
} : undefined,
});

if (options.noAuth && options.host === "0.0.0.0" || options.allowHttp && options.host === "0.0.0.0") {
logger.warn("0.0.0.0 is accessible to every device on the network you're connected to. Make sure you set up authentication to prevent unauthorized access.");
}
logger.info("Starting webserver...", field("host", options.host), field("port", options.port));
app.server.listen(options.port, options.host);
let clientId = 1;
Expand Down