Skip to content

feat(testing): refactor humanPath and add tests #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Nov 15, 2021

This PR refactors humanPath to be pure (i.e. no side effects) and it adds two tests for the function.

Fixes N/A

#TestingMondays

@jsjoeio jsjoeio added the testing Anything related to testing label Nov 15, 2021
@jsjoeio jsjoeio added this to the 3.12.2 - improve iPad UX milestone Nov 15, 2021
@jsjoeio jsjoeio self-assigned this Nov 15, 2021
@jsjoeio jsjoeio marked this pull request as ready for review November 15, 2021 19:04
@jsjoeio jsjoeio requested a review from a team as a code owner November 15, 2021 19:04
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jsjoeio jsjoeio force-pushed the jsjoeio-add-test-humanpath branch from c559246 to 5c32807 Compare November 15, 2021 19:13
@github-actions
Copy link

github-actions bot commented Nov 15, 2021

✨ Coder.com for PR #4511 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #4511 (8c40d11) into main (16a5f2e) will increase coverage by 0.10%.
The diff coverage is 75.00%.

❗ Current head 8c40d11 differs from pull request most recent head 5c32807. Consider uploading reports for the commit 5c32807 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
+ Coverage   65.93%   66.03%   +0.10%     
==========================================
  Files          30       30              
  Lines        1638     1640       +2     
  Branches      330      330              
==========================================
+ Hits         1080     1083       +3     
+ Misses        475      474       -1     
  Partials       83       83              
Impacted Files Coverage Δ
src/node/cli.ts 80.62% <0.00%> (ø)
src/node/main.ts 50.00% <66.66%> (+0.53%) ⬆️
src/node/routes/login.ts 82.14% <100.00%> (+0.32%) ⬆️
src/node/util.ts 77.41% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a5f2e...5c32807. Read the comment docs.

@repo-ranger repo-ranger bot merged commit 0a072f7 into main Nov 15, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio-add-test-humanpath branch November 15, 2021 19:40
@jsjoeio jsjoeio modified the milestones: 4.1.0 - improve iPad UX, 4.0.0 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants