Skip to content

fix: add codeServerVersion to vscode/product.json #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 15, 2021

This PR fixes the code-server version in "Help: About"

Before

image

After

image

Fixes #4629

@jsjoeio jsjoeio self-assigned this Dec 15, 2021
@jsjoeio jsjoeio changed the title fix: add codeServerVersion to vscode/product/json fix: add codeServerVersion to vscode/product.json Dec 15, 2021
@jsjoeio jsjoeio added the bug Something isn't working label Dec 15, 2021
@jsjoeio jsjoeio marked this pull request as ready for review December 15, 2021 23:34
@jsjoeio jsjoeio requested a review from a team as a code owner December 15, 2021 23:34
@github-actions
Copy link

github-actions bot commented Dec 15, 2021

✨ Coder.com for PR #4632 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #4632 (52f4621) into main (c4c480a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4632   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files          30       30           
  Lines        1655     1655           
  Branches      341      341           
=======================================
  Hits         1140     1140           
  Misses        438      438           
  Partials       77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c480a...52f4621. Read the comment docs.

@jsjoeio jsjoeio requested a review from a team December 16, 2021 23:38
@jsjoeio jsjoeio merged commit 95d965a into main Dec 17, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-help-about branch December 17, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version is missing in Help: About
2 participants