fix: package bin/helper directory in the right spot #4776

code-asher · 2022-01-20T21:49:40Z

VS Code moves this as part of their packaging task. We will probably
want to look into using theirs instead of replicating it.

Fixes #4721

VS Code moves this as part of their packaging task. We will probably want to look into using theirs instead of replicating it. Fixes coder#4721

codecov · 2022-01-20T21:59:57Z

Codecov Report

Merging #4776 (d65331f) into main (6e04501) will not change coverage.
The diff coverage is n/a.

❗ Current head d65331f differs from pull request most recent head 467c611. Consider uploading reports for the commit 467c611 to get more accurate results

@@           Coverage Diff           @@
##             main    #4776   +/-   ##
=======================================
  Coverage   69.18%   69.18%           
=======================================
  Files          29       29           
  Lines        1652     1652           
  Branches      363      363           
=======================================
  Hits         1143     1143           
  Misses        432      432           
  Partials       77       77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e04501...467c611. Read the comment docs.

jsjoeio

That is unusual they change the path in production 🤔 I guess we'll have to investigate later. Thanks for fixing this!

code-asher · 2022-01-21T16:54:15Z

Happens here btw:

https://github.com/coder/vscode/blob/5f069ef211aa08b23864032532b1161309ce03c7/src/vs/server/extensionHostConnection.ts#L36

And here is the build step:

https://github.com/coder/vscode/blob/5f069ef211aa08b23864032532b1161309ce03c7/build/gulpfile.reh.js#L329-L333

VS Code moves this as part of their packaging task. We will probably want to look into using theirs instead of replicating it. Fixes coder#4721

Package bin/helper directory in the right spot

467c611

VS Code moves this as part of their packaging task. We will probably want to look into using theirs instead of replicating it. Fixes coder#4721

code-asher requested a review from a team January 20, 2022 21:49

code-asher changed the title ~~Package bin/helper directory in the right spot~~ fix: package bin/helper directory in the right spot Jan 20, 2022

jsjoeio approved these changes Jan 20, 2022

View reviewed changes

code-asher merged commit 63f99da into coder:main Jan 21, 2022

code-asher deleted the browser-script branch January 21, 2022 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: package bin/helper directory in the right spot #4776

fix: package bin/helper directory in the right spot #4776

code-asher commented Jan 20, 2022

codecov bot commented Jan 20, 2022

jsjoeio left a comment

code-asher commented Jan 21, 2022

fix: package bin/helper directory in the right spot #4776

fix: package bin/helper directory in the right spot #4776

Conversation

code-asher commented Jan 20, 2022

codecov bot commented Jan 20, 2022

Codecov Report

jsjoeio left a comment

Choose a reason for hiding this comment

code-asher commented Jan 21, 2022