Skip to content

feat: Add support for imagePullSecrets to Helm chart #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2022
Merged

feat: Add support for imagePullSecrets to Helm chart #4838

merged 5 commits into from
Feb 14, 2022

Conversation

somerandow
Copy link
Contributor

Fixes #
No issue created. Fix is very minor, but I can open an issue if needed.

Adds support for imagePullSecrets, which is defined as a top-level key in the values.yaml, but not previously used in the deployment template.
This PR adds support for imagePullSecrets into the deployment template, which is useful for users that may need to extend the default code-server image (installing additional language support, etc.) and as such may need to pull an image from a private container registry.

This should be a non-breaking change, as imagePullSecrets is defaulted to an empty array in the values.yaml

jsjoeio
jsjoeio reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I think this sounds good to me but I'd like to get another opinion since I'm not a Helm expert.

cc @Matthew-Beckett @bpmct @jawnsy

@Matthew-Beckett
Copy link
Contributor

Hi @WojoInc

Thanks for your contribution, looks fine for me, the only thing I would like to mention is could you please add a null value list of image pull secrets to the values file as we do for other null value objects?

This just makes it easier for people to know what is override-able by looking at the values.yaml file.

Thanks!
Matt

@codecov
Copy link

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #4838 (08dbdfc) into main (c9c5c54) will not change coverage.
The diff coverage is n/a.

❗ Current head 08dbdfc differs from pull request most recent head 0cdab3d. Consider uploading reports for the commit 0cdab3d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4838   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          29       29           
  Lines        1645     1645           
  Branches      363      363           
=======================================
  Hits         1147     1147           
  Misses        424      424           
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c5c54...0cdab3d. Read the comment docs.

@somerandow
Copy link
Contributor Author

So the imagePullSecrets key was already in the values.yaml, so I added a short doc explaining it and an example value. Is this kinda what you were thinking @Matthew-Beckett?

@jsjoeio jsjoeio changed the title Add support for imagePullSecrets to Helm chart feat: Add support for imagePullSecrets to Helm chart Feb 9, 2022
Matthew-Beckett
Matthew-Beckett approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@Matthew-Beckett Matthew-Beckett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all good! Good to merge! Thanks again!

❤️

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 14, 2022

Once this is up to date, I will merge!

@jsjoeio jsjoeio merged commit 3ad618d into coder:main Feb 14, 2022
@jsjoeio jsjoeio added this to the 4.0.3 milestone Feb 14, 2022
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Feb 14, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@somerandow @jsjoeio @TinLe
feat: Add support for imagePullSecrets to Helm chart (coder#4838)
2e661d4 
* add support for imagePullSecrets

* Add doc and example value for imagePullSecrets

* simplify syntax for imagePullSecrets

Co-authored-by: Joe Previte <jjprevite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawnsy jawnsy jawnsy left review comments

@Matthew-Beckett Matthew-Beckett Matthew-Beckett approved these changes

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@somerandow @Matthew-Beckett @jsjoeio @jawnsy