Skip to content

docs: update docs preview #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2022
Merged

docs: update docs preview #4968

merged 4 commits into from
Mar 10, 2022

Conversation

BrunoQuaresma
Copy link
Contributor

Updates:

  • No need to deploy a website preview
  • Supports commit hashes in the URL
  • Probably it will work good with forks

@BrunoQuaresma BrunoQuaresma requested a review from a team March 9, 2022 19:31
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited
Loading

✨ code-server docs for PR #4968 is ready! It will be updated on every commit.

jsjoeio
jsjoeio suggested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! 🎉

A couple questions + you'll need to fix the formatting

@BrunoQuaresma BrunoQuaresma requested a review from jsjoeio March 10, 2022 13:26
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #4968 (55284fe) into main (03e0bda) will not change coverage.
The diff coverage is n/a.

❗ Current head 55284fe differs from pull request most recent head 814e908. Consider uploading reports for the commit 814e908 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4968   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files          29       29           
  Lines        1678     1678           
  Branches      372      372           
=======================================
  Hits         1184     1184           
  Misses        420      420           
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e0bda...814e908. Read the comment docs.

@BrunoQuaresma BrunoQuaresma temporarily deployed to npm March 10, 2022 13:35 Inactive
jsjoeio
jsjoeio approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @BrunoQuaresma 🎉

@jsjoeio jsjoeio merged commit 52eaea9 into main Mar 10, 2022
@jsjoeio jsjoeio deleted the update-docs-preview branch March 10, 2022 20:44
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
@BrunoQuaresma @TinLe
docs: update docs preview (coder#4968)
51231ec 
* docs: update docs preview

* Fix Ubuntu  deps

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @jsjoeio