feat: add tests for isWsl #5251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ code-server docs for PR #5251 is ready! It will be updated on every commit.
|
jsjoeio
commented
Jun 8, 2022
test/unit/node/util.test.ts
Outdated
Comment on lines
488
to
498
| const testDir = path.join(tmpdir, "tests", "isWsl-linux-microsoft") | ||
| let pathToFile = "" | ||
|
|
||
| beforeEach(async () => { | ||
| pathToFile = path.join(testDir, "/proc-version") | ||
| await fs.mkdir(testDir, { recursive: true }) | ||
| await fs.writeFile(pathToFile, "microsoft") | ||
| }) | ||
| afterEach(async () => { | ||
| await fs.rm(testDir, { recursive: true, force: true }) | ||
| }) |
There was a problem hiding this comment.
I tried taking these lines and making a setupIsWslTest but Jest couldn't comprehend the inner beforeEach and afterEach so I ditched it.
Codecov Report
@@ Coverage Diff @@
## main #5251 +/- ##
==========================================
+ Coverage 71.85% 72.00% +0.14%
==========================================
Files 30 30
Lines 1663 1668 +5
Branches 367 367
==========================================
+ Hits 1195 1201 +6
+ Misses 401 400 -1
Partials 67 67
Continue to review full report at Codecov.
|
code-asher
reviewed
Jun 9, 2022
code-asher
approved these changes
Jun 9, 2022
Co-authored-by: Asher <ash@coder.com>
Co-authored-by: Asher <ash@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5153
TODOs
darwinand no/proc/versionfile