Skip to content

fix: logout appearing with auth=none #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

fix: logout appearing with auth=none #5449

merged 1 commit into from
Aug 11, 2022

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Aug 11, 2022 •
edited
Loading

Fixes #5448

@code-asher code-asher requested a review from a team August 11, 2022 15:35
jsjoeio
jsjoeio approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@code-asher code-asher merged commit 17aaa8b into coder:main Aug 11, 2022
@code-asher code-asher deleted the logout branch August 11, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Sign out available even with --auth none
2 participants
@code-asher @jsjoeio