Skip to content

Fix/redesign dialogs #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Fix/redesign dialogs #629

wants to merge 15 commits into from

Conversation

nol166
Copy link
Contributor

@nol166 nol166 commented May 1, 2019

Describe in detail the problem you had and how this PR fixes it

Redesign of the "move to trash" and "open" dialogs. Adds manual path entry.

Is there an open issue you can link to?

n/a

@nol166 nol166 marked this pull request as ready for review May 2, 2019 01:02
@jeasonstudio
Copy link
Contributor

@nol166 Whether to consider refactoring showOpenDialog, use the quickPick provided by vscode to select a file or dir. Just like the picture below(vscode-insiders + remote development ext):

image

@code-asher
Copy link
Member

Closed in favor of #857 which uses the same dialog used by the VS Code's remote extensions.

@code-asher code-asher closed this Jul 18, 2019
@code-asher code-asher deleted the fix/redesign-dialogs branch July 18, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants