Initialize Sail for the repository #719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
reviewed
Aug 19, 2019
There was a problem hiding this comment.
You want to use yarn here instead of npm so no need for package-lock.json.
See https://github.com/cdr/code-server/blob/master/Dockerfile for the deps you want in the Sail dockerfile.
|
@roberthmiller We really appreciate your work here but for now we've determined its best not to add Sail to this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sail
The reasoning for using
codercom/ubuntu-devinstead ofcodercom/ubuntu-dev-node12is because yarn was producing an install error because of some deprecated.nodepackages.This currently does not resolve #713 but aims to eventually solve that by providing a consistent environment.
I would like some help since I am getting this error:
when trying to build code-server through Sail. Is there a dependency that I need to add to the sail Dockerfile?