Change Fetch for onigasm to use credentials #846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can this be added to the next release that is currently in preview |
|
Feel free to reopen this PR against the web branch and close this one. Since it's a very small change it should be OK. |
|
can this now be rebased onto master, since v2 was just merged? |
|
@code-asher cc |
|
I tested this behind a proxy but it seems to work on Chrome and Firefox as-is on v2. Ah it looks like Firefox was changed in 61.0b13 (somewhere around June) to use |
|
Can this be closed then? |
|
I think so, unless we need to support older Firefox or Chrome versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will cause credentials to be used to fetch onigasm so that it will work behind a proxy that is validating client certificates.
Issue:
fetching .wasm does not work behind proxy #845