Test database business logic #25241

Triggered via pull request August 1, 2024 19:18

dannykopping

synchronize #14098

dk/notification-prefs/user-prefs

Status Failure

Total duration 12m 0s

Artifacts 2

ci.yaml

on: pull_request

changes

dependency-license-review

10s

build

Matrix: test-e2e

Matrix: test-go

test-go-tailnet-integration

Annotations

20 errors and 3 warnings

lint: coderd/notifications.go#L231

ruleguard: Message "updated" is too short, it must be at least 16 characters long. (gocritic)

lint: enterprise/coderd/notifications_test.go#L113

ruleguard: This client is operating as the owner user, which has unrestricted permissions. Consider creating a different user. (gocritic)

lint: enterprise/coderd/notifications_test.go#L171

G601: Implicit memory aliasing in for loop. (gosec)

lint: codersdk/notifications.go#L71

var-naming: method parameter notificationTemplateId should be notificationTemplateID (revive)

lint: coderd/notifications/notifier.go#L146

empty-lines: extra empty line at the start of a block (revive)

lint: coderd/database/dbmem/dbmem.go#L2717

unused-receiver: method receiver 'q' is not referenced in method's body, consider removing or renaming it as _ (revive)

lint: coderd/database/dbmem/dbmem.go#L2713

var-naming: method GetNotificationTemplateById should be GetNotificationTemplateByID (revive)

lint: coderd/database/dbmem/dbmem.go#L7549

var-naming: method UpdateNotificationTemplateMethodById should be UpdateNotificationTemplateMethodByID (revive)

lint: coderd/database/dbauthz/dbauthz.go#L1477

var-naming: method GetNotificationTemplateById should be GetNotificationTemplateByID (revive)

lint: coderd/database/dbauthz/dbauthz.go#L3036

var-naming: method UpdateNotificationTemplateMethodById should be UpdateNotificationTemplateMethodByID (revive)

gen