Skip to content

Commit 05ca60e

Browse files
committed
Fix spacing
1 parent 97d32a3 commit 05ca60e

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

coderd/database/dbfake/dbfake.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6648,7 +6648,8 @@ func (q *FakeQuerier) GetAuthorizedWorkspaces(ctx context.Context, arg database.
66486648
statusMatch = job.JobStatus == database.ProvisionerJobStatusSucceeded &&
66496649
build.Transition == database.WorkspaceTransitionStop
66506650
case database.WorkspaceStatusRunning:
6651-
statusMatch = job.JobStatus == database.ProvisionerJobStatusSucceeded
6651+
statusMatch = job.JobStatus == database.ProvisionerJobStatusSucceeded &&
6652+
build.Transition == database.WorkspaceTransitionStart
66526653
default:
66536654
statusMatch = job.JobStatus == database.ProvisionerJobStatus(arg.Status)
66546655
if !statusMatch {

coderd/database/queries/workspaces.sql

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,13 @@ WHERE
154154
latest_build.job_status = 'succeeded'::provisioner_job_status AND
155155
latest_build.transition = 'start'::workspace_transition
156156

157-
-- Special case. A workspace status of "running" is a job status
158-
-- of "succeeded". This is annoying...
157+
-- Special case where the provisioner status and workspace status
158+
-- differ. A workspace is "running" if the job is "succeeded" and
159+
-- the transition is "start". This is because a workspace starts
160+
-- running when a job is complete.
159161
WHEN @status = 'running' THEN
160-
latest_build.job_status = 'succeeded'::provisioner_job_status
162+
latest_build.job_status = 'succeeded'::provisioner_job_status AND
163+
latest_build.transition = 'start'::workspace_transition
161164

162165
WHEN @status != '' THEN
163166
-- By default just match the job status exactly

0 commit comments

Comments
 (0)