fix(coder): properly check for missing organization membership

coadler · web-flow · commit 19dbf1917769 · 2023-10-06T14:57:21.000-05:00
Fixes a possible panic introduced in #9781.
diff --git a/coderd/users.go b/coderd/users.go
@@ -1167,12 +1167,12 @@ func convertUsers(users []database.User, organizationIDsByUserID map[uuid.UUID][
 
 func userOrganizationIDs(ctx context.Context, api *API, user database.User) ([]uuid.UUID, error) {
 	organizationIDsByMemberIDsRows, err := api.Database.GetOrganizationIDsByMemberIDs(ctx, []uuid.UUID{user.ID})
-	if errors.Is(err, sql.ErrNoRows) {
-		return []uuid.UUID{}, xerrors.Errorf("user %q must be a member of at least one organization", user.Email)
-	}
 	if err != nil {
 		return []uuid.UUID{}, err
 	}
+	if len(organizationIDsByMemberIDsRows) == 0 {
+		return []uuid.UUID{}, xerrors.Errorf("user %q must be a member of at least one organization", user.Email)
+	}
 	member := organizationIDsByMemberIDsRows[0]
 	return member.OrganizationIDs, nil
 }
