pr review

f0ssel · f0ssel · commit 23528caf6df6 · 2022-09-29T18:31:33.000Z
diff --git a/site/src/components/WorkspaceQuota/WorkspaceQuota.tsx b/site/src/components/WorkspaceQuota/WorkspaceQuota.tsx
@@ -51,7 +51,7 @@ export const WorkspaceQuota: FC<WorkspaceQuotaProps> = ({ quota, error }) => {
 
   // don't show if limit is 0, this means the feature is disabled.
   if (quota.user_workspace_limit === 0) {
-    return <></>
+    return null
   }
 
   let value = Math.round((quota.user_workspace_count / quota.user_workspace_limit) * 100)
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -100,23 +100,20 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
             error={props.createWorkspaceErrors[CreateWorkspaceErrors.GET_TEMPLATES_ERROR]}
           />
         ) : (
-          <></>
+          null
         )}
         {props.createWorkspaceErrors[CreateWorkspaceErrors.GET_TEMPLATE_SCHEMA_ERROR] ? (
           <ErrorSummary
             error={props.createWorkspaceErrors[CreateWorkspaceErrors.GET_TEMPLATE_SCHEMA_ERROR]}
           />
         ) : (
-          <></>
+          null
         )}
       </Stack>
     )
   }
 
-  const canSubmit =
-    props.quota && props.quota.user_workspace_limit > 0
-      ? props.quota.user_workspace_count < props.quota.user_workspace_limit
-      : true
+  const canSubmit = props.quota && props.quota.user_workspace_limit > 0 && props.quota.user_workspace_count < props.quota.user_workspace_limit
 
   return (
     <FullPageForm title="Create workspace" onCancel={props.onCancel}>
@@ -127,7 +124,7 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
               error={props.createWorkspaceErrors[CreateWorkspaceErrors.CREATE_WORKSPACE_ERROR]}
             />
           ) : (
-            <></>
+            null
           )}
           <TextField
             disabled
@@ -176,7 +173,7 @@ export const CreateWorkspacePageView: FC<React.PropsWithChildren<CreateWorkspace
                   }
                 />
               ) : (
-                <></>
+                null
               )}
 
               <FormFooter

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export const WorkspaceQuota: FC<WorkspaceQuotaProps> = ({ quota, error }) => {`
`51`	`51`
`52`	`52`	`// don't show if limit is 0, this means the feature is disabled.`
`53`	`53`	`if (quota.user_workspace_limit === 0) {`
`54`		`- return <></>`
	`54`	`+ return null`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`let value = Math.round((quota.user_workspace_count / quota.user_workspace_limit) * 100)`