fix: workspace proxy command app link href

Emyrk · Emyrk · commit 2ca2b35546c0 · 2024-01-04T15:36:47.000-06:00
diff --git a/site/src/utils/apps.ts b/site/src/utils/apps.ts
@@ -20,7 +20,10 @@ export const createAppLinkHref = (
     agent.name
   }/apps/${encodeURIComponent(appSlug)}/`;
   if (app.command) {
-    href = `${preferredPathBase}/@${username}/${workspace.name}.${
+    // Terminal links are relative. The terminal page knows how
+    // to select the correct workspace proxy for the websocket
+    // connection.
+    href = `/@${username}/${workspace.name}.${
       agent.name
     }/terminal?command=${encodeURIComponent(app.command)}`;
   }
