test: improve tests and docs

evgeniy-scherbina · evgeniy-scherbina · commit 340f410c8a12 · 2025-06-04T16:42:05.000Z
diff --git a/coderd/schedule/cron/cron.go b/coderd/schedule/cron/cron.go
@@ -155,6 +155,13 @@ func (s Schedule) Next(t time.Time) time.Time {
 	return s.sched.Next(t)
 }
 
+// IsWithinRange interprets a cron spec as a continuous time range,
+// and returns whether the provided time value falls within that range.
+//
+// For example, the expression "* 9-18 * * 1-5" should represent a continuous time range
+// from 09:00 to 18:59, Monday through Friday.
+// However, due to minor implementation imprecision, it is interpreted as
+// a range from 08:59:00 to 18:58:59, Monday through Friday.
 func (s Schedule) IsWithinRange(t time.Time) bool {
 	// Get the next scheduled time
 	next := s.Next(t)
diff --git a/coderd/schedule/cron/cron_test.go b/coderd/schedule/cron/cron_test.go
@@ -171,6 +171,7 @@ func TestIsWithinRange(t *testing.T) {
 		at                  time.Time
 		expectedWithinRange bool
 	}{
+		// "* 9-18 * * 1-5" should be interpreted as a continuous time range from 08:59:00 to 18:58:59, Monday through Friday
 		{
 			name:                "Right before the start of the time range",
 			spec:                "* 9-18 * * 1-5",
@@ -225,6 +226,18 @@ func TestIsWithinRange(t *testing.T) {
 			at:                  mustParseTime(t, time.RFC1123, "Mon, 02 Jun 2025 02:00:00 UTC"),
 			expectedWithinRange: false,
 		},
+		{
+			name:                "Outside the day range #1",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Sat, 07 Jun 2025 14:00:00 UTC"),
+			expectedWithinRange: false,
+		},
+		{
+			name:                "Outside the day range #2",
+			spec:                "* 9-18 * * 1-5",
+			at:                  mustParseTime(t, time.RFC1123, "Sun, 08 Jun 2025 14:00:00 UTC"),
+			expectedWithinRange: false,
+		},
 	}
 
 	for _, testCase := range testCases {
