Fix it even better

ammario · ammario · commit 358217577d20 · 2023-03-23T21:38:00.000Z
diff --git a/site/src/components/Resources/AgentMetadata.tsx b/site/src/components/Resources/AgentMetadata.tsx
@@ -53,14 +53,11 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {
 }
 
 export interface AgentMetadataViewProps {
-  metadata?: WorkspaceAgentMetadata[]
+  metadata: WorkspaceAgentMetadata[]
 }
 
 export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {
   const styles = useStyles()
-  if (metadata === undefined) {
-    return <CircularProgress size={16} />
-  }
   if (metadata.length === 0) {
     return <></>
   }
@@ -102,7 +99,11 @@ export const AgentMetadata: FC<{
     }
   }, [agent.id, watchAgentMetadata])
 
-  return AgentMetadataView({ metadata })
+  if (metadata === undefined) {
+    return <CircularProgress size={16} />
+  }
+
+  return <AgentMetadataView metadata={metadata} />
 }
 
 // These are more or less copied from

Original file line number	Diff line number	Diff line change
`@@ -53,14 +53,11 @@ const MetadataItem: FC<{ item: WorkspaceAgentMetadata }> = ({ item }) => {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`export interface AgentMetadataViewProps {`
`56`		`- metadata?: WorkspaceAgentMetadata[]`
	`56`	`+ metadata: WorkspaceAgentMetadata[]`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`export const AgentMetadataView: FC<AgentMetadataViewProps> = ({ metadata }) => {`
`60`	`60`	`const styles = useStyles()`
`61`		`- if (metadata === undefined) {`
`62`		`- return <CircularProgress size={16} />`
`63`		`- }`
`64`	`61`	`if (metadata.length === 0) {`
`65`	`62`	`return <></>`
`66`	`63`	`}`
`@@ -102,7 +99,11 @@ export const AgentMetadata: FC<{`
`102`	`99`	`}`
`103`	`100`	`}, [agent.id, watchAgentMetadata])`
`104`	`101`
`105`		`- return AgentMetadataView({ metadata })`
	`102`	`+ if (metadata === undefined) {`
	`103`	`+ return <CircularProgress size={16} />`
	`104`	`+ }`
	`105`	`+`
	`106`	`+ return <AgentMetadataView metadata={metadata} />`
`106`	`107`	`}`
`107`	`108`
`108`	`109`	`// These are more or less copied from`