fix(cli/ssh): prevent stdin/stdout reads/writes in stdio mode

mafredri · mafredri · commit 3793256b6790 · 2024-02-07T12:27:15.000+02:00
Fixes #11530
diff --git a/cli/ssh.go b/cli/ssh.go
@@ -87,6 +87,14 @@ func (r *RootCmd) ssh() *clibase.Cmd {
 				}
 			}()
 
+			// In stdio mode, we can't allow any writes to stdin or stdout
+			// because they are used by the SSH protocol.
+			stdioReader, stdioWriter := inv.Stdin, inv.Stdout
+			if stdio {
+				inv.Stdin = stdioWarnReader{inv.Logger}
+				inv.Stdout = inv.Stderr
+			}
+
 			// This WaitGroup solves for a race condition where we were logging
 			// while closing the log file in a defer. It probably solves
 			// others too.
@@ -234,7 +242,7 @@ func (r *RootCmd) ssh() *clibase.Cmd {
 				if err != nil {
 					return xerrors.Errorf("connect SSH: %w", err)
 				}
-				copier := newRawSSHCopier(logger, rawSSH, inv.Stdin, inv.Stdout)
+				copier := newRawSSHCopier(logger, rawSSH, stdioReader, stdioWriter)
 				if err = stack.push("rawSSHCopier", copier); err != nil {
 					return err
 				}
@@ -987,3 +995,12 @@ func sshDisableAutostartOption(src *clibase.Bool) clibase.Option {
 		Default:     "false",
 	}
 }
+
+type stdioWarnReader struct {
+	l slog.Logger
+}
+
+func (r stdioWarnReader) Read(p []byte) (n int, err error) {
+	r.l.Warn(context.Background(), "reading from stdin in stdio mode is not supported")
+	return 0, io.EOF
+}
