wait medium

mafredri · mafredri · commit 3dd31745962c · 2025-05-08T13:26:58.000Z
diff --git a/coderd/notifications/manager_test.go b/coderd/notifications/manager_test.go
@@ -188,14 +188,17 @@ func TestRunStopRace(t *testing.T) {
 	// SETUP
 
 	// nolint:gocritic // Unit test.
-	ctx := dbauthz.AsSystemRestricted(testutil.Context(t, testutil.WaitSuperLong))
+	ctx := dbauthz.AsSystemRestricted(testutil.Context(t, testutil.WaitMedium))
 	store, ps := dbtestutil.NewDB(t)
 	logger := testutil.Logger(t)
 
 	// GIVEN: a standard manager
 	mgr, err := notifications.NewManager(defaultNotificationsConfig(database.NotificationMethodSmtp), store, ps, defaultHelpers(), createMetrics(), logger.Named("notifications-manager"))
 	require.NoError(t, err)
 
+	// Start Run and Stop after each other (run does "go loop()").
+	// This is to catch a (now fixed) race condition where the manager
+	// would be accessed/stopped while it was being created/starting up.
 	mgr.Run(ctx)
 	err = mgr.Stop(ctx)
 	require.NoError(t, err)
