Add test case for invalid tokens

kylecarbs · kylecarbs · commit 424579edeb27 · 2022-07-31T18:39:56.000Z
diff --git a/coderd/userauth.go b/coderd/userauth.go
@@ -48,13 +48,6 @@ func (api *API) userAuthMethods(rw http.ResponseWriter, _ *http.Request) {
 }
 
 func (api *API) userOAuth2Github(rw http.ResponseWriter, r *http.Request) {
-	if api.GithubOAuth2Config == nil {
-		httpapi.Write(rw, http.StatusPreconditionRequired, codersdk.Response{
-			Message: "GitHub authentication is not enabled!",
-		})
-		return
-	}
-
 	state := httpmw.OAuth2(r)
 
 	oauthClient := oauth2.NewClient(r.Context(), oauth2.StaticTokenSource(state.Token))
@@ -227,13 +220,6 @@ type OIDCConfig struct {
 }
 
 func (api *API) userOIDC(rw http.ResponseWriter, r *http.Request) {
-	if api.OIDCConfig == nil {
-		httpapi.Write(rw, http.StatusPreconditionRequired, codersdk.Response{
-			Message: "OpenID Connect authentication is not enabled!",
-		})
-		return
-	}
-
 	state := httpmw.OAuth2(r)
 
 	// See the example here: https://github.com/coreos/go-oidc
diff --git a/coderd/userauth_test.go b/coderd/userauth_test.go
@@ -340,6 +340,46 @@ func TestUserOIDC(t *testing.T) {
 			}
 		})
 	}
+
+	t.Run("Disabled", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t, nil)
+		resp := oidcCallback(t, client)
+		require.Equal(t, http.StatusPreconditionRequired, resp.StatusCode)
+	})
+
+	t.Run("NoIDToken", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t, &coderdtest.Options{
+			OIDCConfig: &coderd.OIDCConfig{
+				OAuth2Config: &oauth2Config{},
+			},
+		})
+		resp := oidcCallback(t, client)
+		require.Equal(t, http.StatusBadRequest, resp.StatusCode)
+	})
+
+	t.Run("BadVerify", func(t *testing.T) {
+		t.Parallel()
+		verifier := oidc.NewVerifier("", &oidc.StaticKeySet{
+			PublicKeys: []crypto.PublicKey{},
+		}, &oidc.Config{})
+
+		client := coderdtest.New(t, &coderdtest.Options{
+			OIDCConfig: &coderd.OIDCConfig{
+				OAuth2Config: &oauth2Config{
+					token: (&oauth2.Token{
+						AccessToken: "token",
+					}).WithExtra(map[string]interface{}{
+						"id_token": "invalid",
+					}),
+				},
+				Verifier: verifier,
+			},
+		})
+		resp := oidcCallback(t, client)
+		require.Equal(t, http.StatusBadRequest, resp.StatusCode)
+	})
 }
 
 // createOIDCConfig generates a new OIDCConfig that returns a static token
