Apply suggestions from code review

johnstcn · web-flow · commit 4899bef8f5c5 · 2024-10-25T14:17:57.000+01:00
diff --git a/provisioner/terraform/tfextract/tfextract.go b/provisioner/terraform/tfextract/tfextract.go
@@ -92,7 +92,7 @@ func WorkspaceTags(ctx context.Context, logger slog.Logger, module *tfconfig.Mod
 				logger.Info(ctx, "workspace tag found", "key", key, "value", value)
 
 				if _, ok := workspaceTags[key]; ok {
-					return nil, xerrors.Errorf(`workspace tag "%s" is defined multiple times`, key)
+					return nil, xerrors.Errorf(`workspace tag %q is defined multiple times`, key)
 				}
 				workspaceTags[key] = value
 			}
@@ -149,7 +149,7 @@ func LoadTerraformVariables(module *tfconfig.Module) ([]*proto.TemplateVariable,
 	return templateVariables, nil
 }
 
-// /convertTerraformVariable converts a Terraform variable to a template-wide variable, processed by Coder.
+// convertTerraformVariable converts a Terraform variable to a template-wide variable, processed by Coder.
 func convertTerraformVariable(variable *tfconfig.Variable) (*proto.TemplateVariable, error) {
 	var defaultData string
 	if variable.Default != nil {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ func WorkspaceTags(ctx context.Context, logger slog.Logger, module *tfconfig.Mod`
`92`	`92`	`logger.Info(ctx, "workspace tag found", "key", key, "value", value)`
`93`	`93`
`94`	`94`	`if _, ok := workspaceTags[key]; ok {`
`95`		- return nil, xerrors.Errorf(`workspace tag "%s" is defined multiple times`, key)
	`95`	+ return nil, xerrors.Errorf(`workspace tag %q is defined multiple times`, key)
`96`	`96`	`}`
`97`	`97`	`workspaceTags[key] = value`
`98`	`98`	`}`
`@@ -149,7 +149,7 @@ func LoadTerraformVariables(module tfconfig.Module) ([]proto.TemplateVariable,`
`149`	`149`	`return templateVariables, nil`
`150`	`150`	`}`
`151`	`151`
`152`		`-// /convertTerraformVariable converts a Terraform variable to a template-wide variable, processed by Coder.`
	`152`	`+// convertTerraformVariable converts a Terraform variable to a template-wide variable, processed by Coder.`
`153`	`153`	`func convertTerraformVariable(variable tfconfig.Variable) (proto.TemplateVariable, error) {`
`154`	`154`	`var defaultData string`
`155`	`155`	`if variable.Default != nil {`