fix: properly check file perms

brettkolodny · brettkolodny · commit 49e5e75d79fe · 2025-05-07T21:36:28.000Z
diff --git a/cli/configssh.go b/cli/configssh.go
@@ -441,7 +441,7 @@ func (r *RootCmd) configSSH() *serpent.Command {
 
 			if !bytes.Equal(configRaw, configModified) {
 				sshDir := filepath.Dir(sshConfigFile)
-				if err := os.MkdirAll(sshDir, os.ModePerm); err != nil {
+				if err := os.MkdirAll(sshDir, 0700); err != nil {
 					return xerrors.Errorf("failed to create directory %q: %w", sshDir, err)
 				}
 
diff --git a/cli/configssh_test.go b/cli/configssh_test.go
@@ -207,7 +207,7 @@ func TestConfigSSH_MissingDirectory(t *testing.T) {
 	// Check that the directory has proper permissions (0700)
 	sshDirInfo, err := os.Stat(sshDir)
 	require.NoError(t, err)
-	require.Equal(t, os.ModePerm, sshDirInfo.Mode().Perm(), "directory should have 0700 permissions")
+	require.Equal(t, os.FileMode(0700), sshDirInfo.Mode().Perm(), "directory should have 0700 permissions")
 }
 
 func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ func (r RootCmd) configSSH() serpent.Command {`
`441`	`441`
`442`	`442`	`if !bytes.Equal(configRaw, configModified) {`
`443`	`443`	`sshDir := filepath.Dir(sshConfigFile)`
`444`		`- if err := os.MkdirAll(sshDir, os.ModePerm); err != nil {`
	`444`	`+ if err := os.MkdirAll(sshDir, 0700); err != nil {`
`445`	`445`	`return xerrors.Errorf("failed to create directory %q: %w", sshDir, err)`
`446`	`446`	`}`
`447`	`447`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func TestConfigSSH_MissingDirectory(t *testing.T) {`
`207`	`207`	`// Check that the directory has proper permissions (0700)`
`208`	`208`	`sshDirInfo, err := os.Stat(sshDir)`
`209`	`209`	`require.NoError(t, err)`
`210`		`- require.Equal(t, os.ModePerm, sshDirInfo.Mode().Perm(), "directory should have 0700 permissions")`
	`210`	`+ require.Equal(t, os.FileMode(0700), sshDirInfo.Mode().Perm(), "directory should have 0700 permissions")`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`func TestConfigSSH_FileWriteAndOptionsFlow(t *testing.T) {`