Skip to content

Commit 4ed5550

Browse files
committed
Extract and refactor a few more topbar componetns
1 parent 84f1bc4 commit 4ed5550

File tree

2 files changed

+18
-11
lines changed

2 files changed

+18
-11
lines changed

site/src/components/FullPageLayout/Topbar.tsx

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import Button, { ButtonProps } from "@mui/material/Button";
22
import IconButton, { IconButtonProps } from "@mui/material/IconButton";
33
import { useTheme } from "@mui/material/styles";
4+
import { Avatar, AvatarProps } from "components/Avatar/Avatar";
45
import { HTMLAttributes, forwardRef } from "react";
56

67
export const Topbar = (props: HTMLAttributes<HTMLDivElement>) => {
@@ -56,7 +57,7 @@ export const TopbarButton = (props: ButtonProps) => {
5657
);
5758
};
5859

59-
export const TopbarDataGroup = (props: HTMLAttributes<HTMLDivElement>) => {
60+
export const TopbarData = (props: HTMLAttributes<HTMLDivElement>) => {
6061
return (
6162
<div
6263
{...props}
@@ -78,3 +79,14 @@ export const TopbarDivider = (props: HTMLAttributes<HTMLSpanElement>) => {
7879
</span>
7980
);
8081
};
82+
83+
export const TopbarAvatar = (props: AvatarProps) => {
84+
return (
85+
<Avatar
86+
{...props}
87+
variant="square"
88+
fitImage
89+
css={{ width: 16, height: 16 }}
90+
/>
91+
);
92+
};

site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import type {
1212
} from "api/typesGenerated";
1313
import { Link as RouterLink } from "react-router-dom";
1414
import { Alert, AlertDetail } from "components/Alert/Alert";
15-
import { Avatar } from "components/Avatar/Avatar";
1615
import { TemplateResourcesTable } from "components/TemplateResourcesTable/TemplateResourcesTable";
1716
import { WorkspaceBuildLogs } from "components/WorkspaceBuildLogs/WorkspaceBuildLogs";
1817
import { PublishVersionData } from "pages/TemplateVersionEditorPage/types";
@@ -47,8 +46,9 @@ import { MONOSPACE_FONT_FAMILY } from "theme/constants";
4746
import { Loader } from "components/Loader/Loader";
4847
import {
4948
Topbar,
49+
TopbarAvatar,
5050
TopbarButton,
51-
TopbarDataGroup,
51+
TopbarData,
5252
TopbarDivider,
5353
TopbarIconButton,
5454
} from "components/FullPageLayout/Topbar";
@@ -201,13 +201,8 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
201201
</Tooltip>
202202
</div>
203203

204-
<TopbarDataGroup>
205-
<Avatar
206-
src={template.icon}
207-
variant="square"
208-
fitImage
209-
css={{ width: 16, height: 16 }}
210-
/>
204+
<TopbarData>
205+
<TopbarAvatar src={template.icon} />
211206
<RouterLink
212207
to={`/templates/${template.name}`}
213208
css={{
@@ -225,7 +220,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
225220
<span css={{ color: theme.palette.text.secondary }}>
226221
{templateVersion.name}
227222
</span>
228-
</TopbarDataGroup>
223+
</TopbarData>
229224

230225
<div
231226
css={{

0 commit comments

Comments
 (0)