lint

johnstcn · johnstcn · commit 50fa1517d204 · 2024-04-12T17:51:30.000+01:00
diff --git a/support/support.go b/support/support.go
@@ -560,19 +560,19 @@ func Summarize(b *Bundle) (msgs []string) {
 		if b.Deployment.HealthReport.ProvisionerDaemons.Error != nil {
 			msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.ProvisionerDaemons.Error)
 		}
-		for _, warn := range *&b.Deployment.HealthReport.ProvisionerDaemons.Warnings {
+		for _, warn := range b.Deployment.HealthReport.ProvisionerDaemons.Warnings {
 			msgs = append(msgs, "Deployment health: "+warn.String())
 		}
 		if b.Deployment.HealthReport.Websocket.Error != nil {
 			msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.Websocket.Error)
 		}
-		for _, warn := range *&b.Deployment.HealthReport.Websocket.Warnings {
+		for _, warn := range b.Deployment.HealthReport.Websocket.Warnings {
 			msgs = append(msgs, "Deployment health: "+warn)
 		}
 		if b.Deployment.HealthReport.WorkspaceProxy.Error != nil {
 			msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.WorkspaceProxy.Error)
 		}
-		for _, warn := range *&b.Deployment.HealthReport.WorkspaceProxy.Warnings {
+		for _, warn := range b.Deployment.HealthReport.WorkspaceProxy.Warnings {
 			msgs = append(msgs, "Deployment health: "+warn.String())
 		}
 	}
diff --git a/support/support_test.go b/support/support_test.go
@@ -249,6 +249,7 @@ func assertNotNilNotEmpty[T any](t *testing.T, v T, msg string) {
 }
 
 func Test_Summarize(t *testing.T) {
+	t.Parallel()
 	for _, tt := range []struct {
 		name     string
 		in       support.Bundle
@@ -275,6 +276,7 @@ func Test_Summarize(t *testing.T) {
 	} {
 		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 			actual := support.Summarize(&tt.in)
 			if len(tt.expected) == 0 {
 				assert.Empty(t, actual)

Original file line number	Diff line number	Diff line change
`@@ -560,19 +560,19 @@ func Summarize(b *Bundle) (msgs []string) {`
`560`	`560`	`if b.Deployment.HealthReport.ProvisionerDaemons.Error != nil {`
`561`	`561`	`msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.ProvisionerDaemons.Error)`
`562`	`562`	`}`
`563`		`- for _, warn := range *&b.Deployment.HealthReport.ProvisionerDaemons.Warnings {`
	`563`	`+ for _, warn := range b.Deployment.HealthReport.ProvisionerDaemons.Warnings {`
`564`	`564`	`msgs = append(msgs, "Deployment health: "+warn.String())`
`565`	`565`	`}`
`566`	`566`	`if b.Deployment.HealthReport.Websocket.Error != nil {`
`567`	`567`	`msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.Websocket.Error)`
`568`	`568`	`}`
`569`		`- for _, warn := range *&b.Deployment.HealthReport.Websocket.Warnings {`
	`569`	`+ for _, warn := range b.Deployment.HealthReport.Websocket.Warnings {`
`570`	`570`	`msgs = append(msgs, "Deployment health: "+warn)`
`571`	`571`	`}`
`572`	`572`	`if b.Deployment.HealthReport.WorkspaceProxy.Error != nil {`
`573`	`573`	`msgs = append(msgs, "Deployment health: "+*b.Deployment.HealthReport.WorkspaceProxy.Error)`
`574`	`574`	`}`
`575`		`- for _, warn := range *&b.Deployment.HealthReport.WorkspaceProxy.Warnings {`
	`575`	`+ for _, warn := range b.Deployment.HealthReport.WorkspaceProxy.Warnings {`
`576`	`576`	`msgs = append(msgs, "Deployment health: "+warn.String())`
`577`	`577`	`}`
`578`	`578`	`}`