fix: coderd/prometheusmetrics wait for all metrics in require.Eventually (#5338)

mtojek · web-flow · commit 534bff2ff545 · 2022-12-07T17:50:17.000+01:00
diff --git a/coderd/prometheusmetrics/prometheusmetrics_test.go b/coderd/prometheusmetrics/prometheusmetrics_test.go
@@ -224,7 +224,9 @@ func TestWorkspaces(t *testing.T) {
 					if !ok {
 						t.Fail()
 					}
-					require.Equal(t, count, int(metric.Gauge.GetValue()), "invalid count for %s", metric.Label[0].GetValue())
+					if metric.Gauge.GetValue() != float64(count) {
+						return false
+					}
 					sum += int(metric.Gauge.GetValue())
 				}
 				t.Logf("sum %d == total %d", sum, tc.Total)

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,9 @@ func TestWorkspaces(t *testing.T) {`
`224`	`224`	`if !ok {`
`225`	`225`	`t.Fail()`
`226`	`226`	`}`
`227`		`- require.Equal(t, count, int(metric.Gauge.GetValue()), "invalid count for %s", metric.Label[0].GetValue())`
	`227`	`+ if metric.Gauge.GetValue() != float64(count) {`
	`228`	`+ return false`
	`229`	`+ }`
`228`	`230`	`sum += int(metric.Gauge.GetValue())`
`229`	`231`	`}`
`230`	`232`	`t.Logf("sum %d == total %d", sum, tc.Total)`